Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [BUG] Bug fix for checksum validation for mapping metadata #15888 #15890

Merged
merged 3 commits into from
Sep 12, 2024
Merged

[Backport 2.x] [BUG] Bug fix for checksum validation for mapping metadata #15888 #15890

merged 3 commits into from
Sep 12, 2024

Conversation

himshikha
Copy link
Contributor

Description

Backport f8515c7 from #15885.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@himshikha
[BUG] Bug fix for checksum validation for mapping metadata (opensearc…
76d085d 
…h-project#15885)

* Bug fix for checksum validation for mapping metadata

Signed-off-by: Himshikha Gupta <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for cbb16d5: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.54%. Comparing base (dc28eb2) to head (cbaf0d2).
Report is 3 commits behind head on 2.x.

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #15890      +/-   ##
============================================
+ Coverage     71.46%   71.54%   +0.07%     
- Complexity    64439    64444       +5     
============================================
  Files          5264     5264              
  Lines        302012   302052      +40     
  Branches      43970    43970              
============================================
+ Hits         215831   216101     +270     
+ Misses        68148    67882     -266     
- Partials      18033    18069      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 4e2ddcb: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testWriteRead
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testRequestStats
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testReadNonExistingPath
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testMultipleSnapshotAndRollback
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testIndicesDeletedFromRepository
      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testDeleteBlobs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

bwc change
4d67722 
Signed-off-by: Himshikha Gupta <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 4d67722: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for cbaf0d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 11, 2024
Open
Open
Open
@himshikha
Copy link
Contributor Author

❌ Gradle check result for cbaf0d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky tests #14289, #14288, #15806

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 11, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for cbaf0d2: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 12, 2024
Open
@Bukhtawar Bukhtawar merged commit 1074c71 into opensearch-project:2.x Sep 12, 2024
34 of 35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
@github-actions
[Backport 2.x] [BUG] Bug fix for checksum validation for mapping met…
327c1f2 
…adata #15888  (#15890)

* [BUG] Bug fix for checksum validation for mapping metadata (#15885)

* Bug fix for checksum validation for mapping metadata

Signed-off-by: Himshikha Gupta <[email protected]>
(cherry picked from commit 1074c71)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 12, 2024
Merged
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 9, 2024
Open
Bukhtawar pushed a commit that referenced this pull request Sep 12, 2024
@opensearch-trigger-bot
[Backport 2.x] [BUG] Bug fix for checksum validation for mapping met…
1dba8c3 
…adata #15888  (#15890) (#15908)

* [BUG] Bug fix for checksum validation for mapping metadata (#15885)

Signed-off-by: Himshikha Gupta <[email protected]>
@himshikha himshikha mentioned this pull request Sep 18, 2024
Closed
@prudhvigodithi prudhvigodithi mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.17 skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himshikha @Bukhtawar